-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate valid passwords when using additional validators #4
feat: generate valid passwords when using additional validators #4
Conversation
(cherry picked from commit d21be1b)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about moving this feature outside this repository?
@@ -11,6 +11,7 @@ | |||
|
|||
from openedx.core.djangoapps.user_api.accounts.utils import handle_retirement_cancellation | |||
from openedx.core.djangoapps.user_api.models import UserRetirementStatus | |||
from openedx.core.djangoapps.user_authn.utils import generate_password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about moving this feature outside this repository?
@andrey-canon Do you think moving it to eox_nelp and somehow monkeypatch Or do you think using a fork of edx_django_utils and change there |
I think both are valid options, probably the ideal one is to fork edx_django_utils and the make then upstream pr, however I'm not sure if this will be approve, so we could start with the monkey patch approach and then migrate it to edx_django_utils |
Reaching the discussion, this PR is closed in favor of eduNEXT/eox-nelp#130 |
Description
(cherry picked from commit d21be1b)
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
install django-password-validators=1.7, set correct settings, add the package to installed apps and migrate it.
Screencast from 22-01-24 15:13:17.webm
Before
Screencast.from.22-01-24.15.10.49.webm
After
Screencast.from.22-01-24.15.15.17.webm
Other information
PRs related
eduNEXT/edunext-platform#676