Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate valid passwords when using additional validators #4

Closed

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Jan 22, 2024

Description

(cherry picked from commit d21be1b)

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

install django-password-validators=1.7, set correct settings, add the package to installed apps and migrate it.
Peek 2024-01-22 15-01
Screencast from 22-01-24 15:13:17.webm

Before

Screencast.from.22-01-24.15.10.49.webm

After

Screencast.from.22-01-24.15.15.17.webm

Other information

PRs related
eduNEXT/edunext-platform#676

Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about moving this feature outside this repository?

@@ -11,6 +11,7 @@

from openedx.core.djangoapps.user_api.accounts.utils import handle_retirement_cancellation
from openedx.core.djangoapps.user_api.models import UserRetirementStatus
from openedx.core.djangoapps.user_authn.utils import generate_password
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no xD

Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about moving this feature outside this repository?

@johanseto
Copy link
Collaborator Author

johanseto commented Jan 26, 2024

what do you think about moving this feature outside this repository?

@andrey-canon Do you think moving it to eox_nelp and somehow monkeypatch generate_password method with the eox-nelp one?.

Or do you think using a fork of edx_django_utils and change there generate_password??

@andrey-canon
Copy link
Collaborator

andrey-canon commented Jan 31, 2024

what do you think about moving this feature outside this repository?

@andrey-canon Do you think moving it to eox_nelp and somehow monkeypatch generate_password method with the eox-nelp one?.

Or do you think using a fork of edx_django_utils and change there generate_password??

I think both are valid options, probably the ideal one is to fork edx_django_utils and the make then upstream pr, however I'm not sure if this will be approve, so we could start with the monkey patch approach and then migrate it to edx_django_utils

@johanseto
Copy link
Collaborator Author

Reaching the discussion, this PR is closed in favor of eduNEXT/eox-nelp#130

@johanseto johanseto closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants